Fix end to end test failures on CI #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goto-bus-stop
commented
Jun 24, 2020
arturi
reviewed
Jun 29, 2020
arturi
reviewed
Jun 29, 2020
goto-bus-stop
commented
Jun 29, 2020
Co-authored-by: Artur Paikin <artur@arturpaikin.com>
arturi
approved these changes
Jun 29, 2020
This was referenced Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chaos monkey test used
canvas.toBlobwhich IE does not have.The react test was probably broken by a Dashboard redesign, but we may not have noticed it because another was probably already broken then... I added a
data-acquirer-idattribute to the DashboardTabs to make it a bit more robust in case there are more design tweaks in the future.Locally the URL plugin test still fails for me with these changes, but I think that's due to some IE driver configuration, as it seems to work fine on saucelabs.